From: Thomas Monjalon <thomas@monjalon.net>
To: Arin Kharkar <arinkharkar@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] Updated skeleton example code to better emit error
Date: Fri, 17 Jul 2026 15:29:52 +0200 [thread overview]
Message-ID: <XTRKMiZcSAmd4Wq2exFNLQ@monjalon.net> (raw)
In-Reply-To: <20260512192834.130651-1-arinkharkar@gmail.com>
12/05/2026 21:28, Arin Kharkar:
> Previously, the program would check if the number of ports is even and if not, would exit with an error stating "the number of ports must be even". To provide more information, the program now states how many ports were found. This is especially helpful if 0 ports were found, as it explicitly states DPDK wasn't able to find any ports, rather than making the user troubleshoot this.
> ---
> examples/skeleton/basicfwd.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/examples/skeleton/basicfwd.c b/examples/skeleton/basicfwd.c
> index 133293cf15..381e4d4273 100644
> --- a/examples/skeleton/basicfwd.c
> +++ b/examples/skeleton/basicfwd.c
> @@ -188,11 +188,9 @@ main(int argc, char *argv[])
> /* Check that there is an even number of ports to send/receive on. */
> nb_ports = rte_eth_dev_count_avail();
> if (nb_ports < 2 || (nb_ports & 1))
> - rte_exit(EXIT_FAILURE, "Error: number of ports must be even\n");
> + rte_exit(EXIT_FAILURE, "Error: number of ports must be even, found %u ports\n", nb_ports);
>
> - /* Creates a new mempool in memory to hold the mbufs. */
> -
> - /* Allocates mempool to hold the mbufs. 8< */
> + /* Creates and allocates a mempool to hold the mbufs. 8< */
Changing this comment requires changing the doc referencing it.
I've made this change, added your signoff and other details,
and applied, thanks.
prev parent reply other threads:[~2026-07-17 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 19:28 [PATCH] Updated skeleton example code to better emit error Arin Kharkar
2026-05-13 16:30 ` Marat Khalili
2026-07-17 13:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=XTRKMiZcSAmd4Wq2exFNLQ@monjalon.net \
--to=thomas@monjalon.net \
--cc=arinkharkar@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox