From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3574BC433ED for ; Thu, 8 Apr 2021 13:05:38 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id A4A2761151 for ; Thu, 8 Apr 2021 13:05:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4A2761151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=sysclose.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B68EF140FA8; Thu, 8 Apr 2021 15:05:36 +0200 (CEST) Received: from sysclose.org (smtp.sysclose.org [69.164.214.230]) by mails.dpdk.org (Postfix) with ESMTP id 3C24240138 for ; Thu, 8 Apr 2021 15:05:35 +0200 (CEST) Received: from localhost (unknown [45.71.105.250]) by sysclose.org (Postfix) with ESMTPSA id 3EE842618; Thu, 8 Apr 2021 13:05:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 sysclose.org 3EE842618 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sysclose.org; s=201903; t=1617887135; bh=7R4WghEJRxXfWqpw1uriTzBZiDCq20FourT9i2BpDxk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I0gWMDA1NQSWLsHPxe0bLjbmLlYwqkqV+5u5sXQEpbY+RK++OytWFGNoPIOfFVoIh GL3Cb44X+4/tx5Zp8CjqyZQpzXmW9HMeXJHYXeNbLm45gM5R/0/XdKxoaAR6i3tWg0 LqfbUISvQ2r86ldLgjOd8u3VQ3ZFNM2TDcE5PNxwNF/aDbqIGT9sQtdgvLEMx4kuEk c+UR4S7SAQy3TFC3weiH32AkFuWUhyjlqG3JtBSasJtV92FJTP+mKMxlXuoC7JrCsX IZFBlRiD7zxNyepTQRiNS7KLMlWkZep+AYb/EHtaLrfgRIsXGrXROm/asTCyztczXP 80u7CWOkGDr4A== Date: Thu, 8 Apr 2021 10:05:30 -0300 From: Flavio Leitner To: David Marchand Cc: dev@dpdk.org, maxime.coquelin@redhat.com, olivier.matz@6wind.com, i.maximets@ovn.org, Chenbo Xia , Bruce Richardson , Konstantin Ananyev , Jerin Jacob , Ruifeng Wang Message-ID: References: <20210401095243.18211-1-david.marchand@redhat.com> <20210401095243.18211-5-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401095243.18211-5-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: refactor Tx offload helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 01, 2021 at 11:52:42AM +0200, David Marchand wrote: > Purely cosmetic but it is rather odd to have an "offload" helper that > checks if it actually must do something. > We already have the same checks in most callers, so move this branch > in them. > > Signed-off-by: David Marchand > --- Reviewed-by: Flavio Leitner