From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E331C07E99 for ; Mon, 5 Jul 2021 10:58:38 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 07E2F61159 for ; Mon, 5 Jul 2021 10:58:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07E2F61159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0933F4068C; Mon, 5 Jul 2021 12:58:37 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4E6CB4003C for ; Mon, 5 Jul 2021 12:58:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10035"; a="294602532" X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="294602532" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 03:58:34 -0700 X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="485465495" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.142]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 Jul 2021 03:58:32 -0700 Date: Mon, 5 Jul 2021 11:58:29 +0100 From: Bruce Richardson To: "Power, Ciara" Cc: "dev@dpdk.org" , Ray Kinsella Message-ID: References: <20210702152305.606933-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 21.11] telemetry: remove experimental tags from APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 05, 2021 at 11:09:38AM +0100, Power, Ciara wrote: > > > >-----Original Message----- > >From: Richardson, Bruce > >Sent: Friday 2 July 2021 16:23 > >To: dev@dpdk.org > >Cc: Ray Kinsella ; Power, Ciara ; > >Richardson, Bruce > >Subject: [PATCH 21.11] telemetry: remove experimental tags from APIs > > > >The telemetry APIs have been present and unchanged for >1 year now, so > >remove experimental tag from them. > > > >Signed-off-by: Bruce Richardson > >--- > > lib/telemetry/rte_telemetry.h | 18 ------------------ > > lib/telemetry/version.map | 2 +- > > 2 files changed, 1 insertion(+), 19 deletions(-) > > > > > Hi Bruce, > > +1 for this change. > > I think there are some experimental tags missing from this patch - the legacy telemetry functions that are in "metrics/rte_metrics_telemetry.h" currently have the tags too. I'm not sure about making those part of the stable ABI. > Also, there is a reference to the library being experimental in the Telemetry User Guide doc. > I missed checking the "howto" doc on telemetry, yes. I'll include that in a v2.