From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC1FC4338F for ; Thu, 29 Jul 2021 16:05:12 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id B67D960184 for ; Thu, 29 Jul 2021 16:05:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B67D960184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=6wind.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE3FB410EF; Thu, 29 Jul 2021 18:05:07 +0200 (CEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 8B8C04067A for ; Thu, 29 Jul 2021 18:05:06 +0200 (CEST) Received: by mail-wr1-f46.google.com with SMTP id n12so7598023wrr.2 for ; Thu, 29 Jul 2021 09:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7oeGG8oafyQSHG0G89bSbpKfXqo7Mkcd5KeE418U2VU=; b=KTLhd4igHPa+DqVscQqtjdNUNDeZfus1wdAD30anlRDzuMoWqAkCekMURlGunMIN7T mQ47XSKHQ5MjTi2yl9vYPbM8Uv0RgLLMTUIt3vq2kSydSuLDgbhvA9VSHCVcJIaO17iN JW0TyIjsvmxdwoPIut46yvvTDjPc4IcVJlqkRomQzWKCVHsR0hetM6tNf0NgQd0GGcTK mfiYZbgfugM5VCczAyOzYhs0K5q8qSXtRCuIwZ8COnHQ02RxTWY1i6qLoiPTvFuBk8A+ zT6mG/hXGOon929kcpDcTUfvxHC2d9EBaIH0iOdYbt+ZUGBVRFFr/7hjRBldSQQb4sOZ pUqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7oeGG8oafyQSHG0G89bSbpKfXqo7Mkcd5KeE418U2VU=; b=MzkEkk62bSjByAf+t58sB5FfYnvo1jd5zbKYSmnH/YPxs6YYAbtuP5K2ixlyBTD2Yc xGQoYUV7ewexuTYP/LWvvkuTUh4XmDcXVIomdpP2wIsJnw3kXZAOGoaHGSgcwiYODU2p IEQ+yiRnRkcP5BReOSb73dEed+7I2YCZEFaxgCchfe+VPmAVpp1pmXUF71UaGX1mtuf7 6OejHA+MvNgjTcvT4rknfpdC507tOYnRun/cRVn0CaZrxLRMfqtLCPtb2zcMpSbZNH7z 8MH/Jf9DIt5dg+mFHFXcAvpqXx4kWuJe86AgEDmIQ9th/e4KFtDKeW0mq72LWtVv3pE9 ssnA== X-Gm-Message-State: AOAM533GbDzB1R7bIkqbbDsMSLAfMAVHS1KZ1PN8MLoDKo0QpI2VyPWS KgcGbLzFL75v9wv04w2AOLLPnA== X-Google-Smtp-Source: ABdhPJxPkLhCoq6U6tykd4GIT0j28YYgSFWkVSe1QI5YG5T8U4gBYRsw+apzC4njwOEFeqg//LehNg== X-Received: by 2002:adf:b30a:: with SMTP id j10mr5490437wrd.43.1627574706253; Thu, 29 Jul 2021 09:05:06 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id z2sm3557449wma.45.2021.07.29.09.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 09:05:05 -0700 (PDT) Date: Thu, 29 Jul 2021 18:05:05 +0200 From: Olivier Matz To: Gregory Etelson Cc: dev@dpdk.org, Ajit Khaparde , Andrew Rybchenko , Ferruh Yigit , Thomas Monjalon , stable@dpdk.org, Xiaoyun Li Message-ID: References: <20210719083309.15428-1-getelson@nvidia.com> <20210729093948.25847-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729093948.25847-1-getelson@nvidia.com> Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: fix TX checksum calculation for tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 29, 2021 at 12:39:48PM +0300, Gregory Etelson wrote: > csumonly engine calculates TX checksum of a tunnelled packet for outer > headers only or separately for outer and inner headers. The > calculation method is determined by checksum configuration options. > If TX checksum calculation is separated, the inner headers are > processed before outer headers. > > Inner headers processing sets checksum values to 0 unconditionally. > If TX configuration offloads inner checksums only, outer checksum > calculation in software will read 0 instead of real values and > produce wrong result. > > The patch zeroes inner checksums only before software calculation. > > Fixes: 51f694dd40f5 ("app/testpmd: rework checksum forward engine") > Cc: stable@dpdk.org As said previously, I think the correct Fixes line is: Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine") Acked-by: Olivier Matz Thanks