From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v4 06/19] vhost: define postcopy protocol flag Date: Tue, 9 Oct 2018 13:47:58 +0200 Message-ID: References: <20181008152557.14275-1-maxime.coquelin@redhat.com> <20181008152557.14275-7-maxime.coquelin@redhat.com> <20181009114129.GB32180@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org To: Tiwei Bie Return-path: In-Reply-To: <20181009114129.GB32180@debian> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/09/2018 01:41 PM, Tiwei Bie wrote: > On Mon, Oct 08, 2018 at 05:25:44PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Dr. David Alan Gilbert >> Signed-off-by: Maxime Coquelin >> Acked-by: Ilya Maximets >> --- >> lib/librte_vhost/rte_vhost.h | 4 ++++ >> 1 file changed, 4 insertions(+) > > Reviewed-by: Tiwei Bie > >> >> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h >> index b02673d4a..b3cc6990d 100644 >> --- a/lib/librte_vhost/rte_vhost.h >> +++ b/lib/librte_vhost/rte_vhost.h >> @@ -66,6 +66,10 @@ extern "C" { >> #define VHOST_USER_PROTOCOL_F_HOST_NOTIFIER 11 >> #endif >> >> +#ifndef VHOST_USER_PROTOCOL_F_PAGEFAULT >> +#define VHOST_USER_PROTOCOL_F_PAGEFAULT 8 >> +#endif > > Do we want to keep these defines sorted? I.e. define it after > VHOST_USER_PROTOCOL_F_CRYPTO_SESSION (which is defined as 7). Yes, makes sense. >> + >> /** Indicate whether protocol features negotiation is supported. */ >> #ifndef VHOST_USER_F_PROTOCOL_FEATURES >> #define VHOST_USER_F_PROTOCOL_FEATURES 30 >> -- >> 2.17.1 >>