From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Subject: [PATCH v1 01/15] net/ixgbe/base: remove minsrevs code from DPDK
Date: Thu, 29 Aug 2024 10:00:06 +0100 [thread overview]
Message-ID: <a16bd1264adbd56fefbf1413f27cde338959f61c.1724921977.git.anatoly.burakov@intel.com> (raw)
Commit add44414762c ("net/ixgbe/base: add E610 NVM-related operations") has
added code to read minimum security revision from NVM. This code was not
meant to be included in DPDK, and was only meant for other drivers derived
from shared base code, but was present due to the way shared driver code
snapshot was generated. Remove this code from DPDK driver.
Fixes: add44414762c ("net/ixgbe/base: add E610 NVM-related operations")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
drivers/net/ixgbe/base/ixgbe_e610.c | 54 -----------------------------
drivers/net/ixgbe/base/ixgbe_e610.h | 1 -
2 files changed, 55 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c b/drivers/net/ixgbe/base/ixgbe_e610.c
index ac71980630..3e2be07731 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -2488,60 +2488,6 @@ static s32 ixgbe_read_nvm_sr_copy(struct ixgbe_hw *hw,
return ixgbe_read_nvm_module(hw, bank, hdr_len + offset, data);
}
-/**
- * ixgbe_get_nvm_minsrevs - Get the minsrevs values from flash
- * @hw: pointer to the HW struct
- * @minsrevs: structure to store NVM and OROM minsrev values
- *
- * Read the Minimum Security Revision TLV and extract
- * the revision values from the flash image
- * into a readable structure for processing.
- *
- * Return: the exit code of the operation.
- */
-s32 ixgbe_get_nvm_minsrevs(struct ixgbe_hw *hw,
- struct ixgbe_minsrev_info *minsrevs)
-{
- struct ixgbe_aci_cmd_nvm_minsrev data;
- s32 status;
- u16 valid;
-
- status = ixgbe_acquire_nvm(hw, IXGBE_RES_READ);
- if (status)
- return status;
-
- status = ixgbe_aci_read_nvm(hw, IXGBE_ACI_NVM_MINSREV_MOD_ID,
- 0, sizeof(data), &data,
- true, false);
-
- ixgbe_release_nvm(hw);
-
- if (status)
- return status;
-
- valid = IXGBE_LE16_TO_CPU(data.validity);
-
- /* Extract NVM minimum security revision */
- if (valid & IXGBE_ACI_NVM_MINSREV_NVM_VALID) {
- u16 minsrev_l = IXGBE_LE16_TO_CPU(data.nvm_minsrev_l);
- u16 minsrev_h = IXGBE_LE16_TO_CPU(data.nvm_minsrev_h);
-
- minsrevs->nvm = minsrev_h << 16 | minsrev_l;
- minsrevs->nvm_valid = true;
- }
-
- /* Extract the OROM minimum security revision */
- if (valid & IXGBE_ACI_NVM_MINSREV_OROM_VALID) {
- u16 minsrev_l = IXGBE_LE16_TO_CPU(data.orom_minsrev_l);
- u16 minsrev_h = IXGBE_LE16_TO_CPU(data.orom_minsrev_h);
-
- minsrevs->orom = minsrev_h << 16 | minsrev_l;
- minsrevs->orom_valid = true;
- }
-
- return IXGBE_SUCCESS;
-}
-
/**
* ixgbe_get_nvm_srev - Read the security revision from the NVM CSS header
* @hw: pointer to the HW struct
diff --git a/drivers/net/ixgbe/base/ixgbe_e610.h b/drivers/net/ixgbe/base/ixgbe_e610.h
index 33c683d1c1..4babee821e 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_e610.h
@@ -85,7 +85,6 @@ s32 ixgbe_aci_read_nvm(struct ixgbe_hw *hw, u16 module_typeid, u32 offset,
s32 ixgbe_nvm_validate_checksum(struct ixgbe_hw *hw);
s32 ixgbe_nvm_recalculate_checksum(struct ixgbe_hw *hw);
-s32 ixgbe_get_nvm_minsrevs(struct ixgbe_hw *hw, struct ixgbe_minsrev_info *minsrevs);
s32 ixgbe_get_inactive_nvm_ver(struct ixgbe_hw *hw, struct ixgbe_nvm_info *nvm);
s32 ixgbe_get_active_nvm_ver(struct ixgbe_hw *hw, struct ixgbe_nvm_info *nvm);
s32 ixgbe_init_nvm(struct ixgbe_hw *hw);
--
2.43.5
next reply other threads:[~2024-08-29 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 9:00 Anatoly Burakov [this message]
2024-08-29 9:00 ` [PATCH v1 02/15] net/ixgbe/base: add missing ACI definitions Anatoly Burakov
2024-09-03 10:32 ` Bruce Richardson
2024-08-29 9:00 ` [PATCH v1 03/15] net/ixgbe/base: add missing E610 definitions Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 04/15] net/ixgbe/base: add missing legacy mailbox API Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 05/15] net/ixgbe/base: add E610 VF HV macro Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 06/15] net/ixgbe/base: fix unchecked return value Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 07/15] net/ixgbe/base: fix media type handling for E610 Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 08/15] net/ixgbe/base: fix speed autonegotiation on E610 Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 09/15] net/ixgbe/base: FW API version update Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 10/15] net/ixgbe/base: handle 5G link speed for E610 Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 11/15] net/ixgbe/base: remove FW API version check Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 12/15] net/ixgbe/base: disable thermal sensor ops for E610 Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 13/15] net/ixgbe/base: fix mailbox ACK handling Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 14/15] net/ixgbe/base: correct NVM access type for EEPROM writes on E610 Anatoly Burakov
2024-08-29 9:00 ` [PATCH v1 15/15] net/ixgbe: add PCI IDs for new device variants Anatoly Burakov
2024-09-03 14:08 ` [PATCH v1 01/15] net/ixgbe/base: remove minsrevs code from DPDK Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a16bd1264adbd56fefbf1413f27cde338959f61c.1724921977.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).