From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 1/6] drivers/common: add mvep common code for
 MRVL PMDs
Date: Fri, 24 Aug 2018 13:32:47 +0100
Message-ID: <a1a4a011-9710-5418-c2fa-1681a5f58f3d@intel.com>
References: <1535113006-9393-1-git-send-email-tdu@semihalf.com>
 <1535113006-9393-2-git-send-email-tdu@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: nsamsono@marvell.com, mw@semihalf.com, Liron Himi <lironh@marvell.com>
To: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 8D66910A3
 for <dev@dpdk.org>; Fri, 24 Aug 2018 14:35:20 +0200 (CEST)
In-Reply-To: <1535113006-9393-2-git-send-email-tdu@semihalf.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/24/2018 1:16 PM, Tomasz Duszynski wrote:
> From: Liron Himi <lironh@marvell.com>
> 
> Add MVEP (Marvell Embedded Processors) to drivers/common which
> will keep code reused by current and future MRVL PMDs.
> Right now we have only common DMA memory initialization routines there.
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>  config/common_base                              |  5 +++
>  devtools/test-build.sh                          |  2 ++
>  drivers/common/Makefile                         |  4 +++
>  drivers/common/meson.build                      |  2 +-
>  drivers/common/mvep/Makefile                    | 38 +++++++++++++++++++++
>  drivers/common/mvep/meson.build                 | 19 +++++++++++
>  drivers/common/mvep/mvep_common.c               | 45 +++++++++++++++++++++++++
>  drivers/common/mvep/rte_common_mvep_version.map |  6 ++++
>  drivers/common/mvep/rte_mvep_common.h           | 20 +++++++++++
>  mk/rte.app.mk                                   |  4 +++
>  10 files changed, 144 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/common/mvep/Makefile
>  create mode 100644 drivers/common/mvep/meson.build
>  create mode 100644 drivers/common/mvep/mvep_common.c
>  create mode 100644 drivers/common/mvep/rte_common_mvep_version.map
>  create mode 100644 drivers/common/mvep/rte_mvep_common.h
> 
> diff --git a/config/common_base b/config/common_base
> index 4bcbaf9..978592d 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -395,6 +395,11 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n
>  CONFIG_RTE_LIBRTE_PMD_FAILSAFE=y
>  
>  #
> +# Compile Marvell Embedded Processors Common
> +#
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=n

Do you need a new config option for common, why not enable it if one of the
consumers of common code enabled?