From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Green Subject: Re: [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code Date: Mon, 14 May 2018 08:09:02 +0800 Message-ID: References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <1908380.h0rCPQG6nq@xps> <2c8be5ff-70ef-6081-31f5-bcbb8a0b1a18@warmcat.com> <1896621.ibENEg8Kdi@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com To: Thomas Monjalon Return-path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id E29E81BE2F for ; Mon, 14 May 2018 02:09:15 +0200 (CEST) In-Reply-To: <1896621.ibENEg8Kdi@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/14/2018 07:44 AM, Thomas Monjalon wrote: > 14/05/2018 01:21, Andy Green: >> >> On 05/14/2018 12:47 AM, Thomas Monjalon wrote: >>> 12/05/2018 03:59, Andy Green: >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: >>>> In function '__rte_ring_move_prod_head': >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: >>>> warning: ISO C90 forbids mixed declarations and code >>>> [-Wdeclaration-after-statement] >>>> const uint32_t cons_tail = r->cons.tail; >>>> ^~~~~ >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: >>>> In function '__rte_ring_move_cons_head': >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:147:3: >>>> warning: ISO C90 forbids mixed declarations and code >>>> [-Wdeclaration-after-statement] >>>> const uint32_t prod_tail = r->prod.tail; >>> >>> The fix line is: >>> Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") >> >> OK... people can just use git blame at the time they want to know this >> though. > > No, we need it to automatically detect which commits should be backported, There is nothing automatic about that flow :-) It's "automatic after every committer did the work manually" you mean. > and in which branch. > > We also add Cc: stable@dpdk.org to confirm explicitly that is must be backported. In other projects this work falls on the maintainer(s). -Andy > >