From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/mrvl: fix build error with gcc
Date: Tue, 27 Mar 2018 20:11:05 +0100
Message-ID: <a2818ed3-b6d0-6fa6-c832-6822bbdfe7be@intel.com>
References: <20180322181847.74246-1-ferruh.yigit@intel.com>
 <20180323075229.GA22697@sh>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Jacek Siuda <jck@semihalf.com>, Dmitri Epshtein <dima@marvell.com>,
 Natalie Samsonov <nsamsono@marvell.com>, Jianbo Liu <jianbo.liu@arm.com>,
 dev@dpdk.org
To: Tomasz Duszynski <tdu@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 154F85F38
 for <dev@dpdk.org>; Tue, 27 Mar 2018 21:11:08 +0200 (CEST)
In-Reply-To: <20180323075229.GA22697@sh>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/23/2018 7:52 AM, Tomasz Duszynski wrote:
> On Thu, Mar 22, 2018 at 06:18:47PM +0000, Ferruh Yigit wrote:
>> gcc version:
>> aarch64-linux-gnu-gcc (Linaro GCC 7.2-2017.11) 7.2.1 20171011
>>
>> build error:
>>   CC mrvl_qos.o
>> .../drivers/net/mrvl/mrvl_qos.c: In function ‘mrvl_configure_rxqs’:
>> .../drivers/net/mrvl/mrvl_qos.c:679:17:
>>   error: ‘sprintf’ may write a terminating nul past the end of the
>>          destination [-Werror=format-overflow=]
>>   sprintf(match, "policer-%d:%d\n", priv->pp_id, priv->ppio_id);
>>                  ^~~~~~~~~~~~~~~~~
>> .../drivers/net/mrvl/mrvl_qos.c:679:2:
>>   note: ‘sprintf’ output between 13 and 17 bytes into a destination
>>         of size 16
>>   sprintf(match, "policer-%d:%d\n", priv->pp_id, priv->ppio_id);
>>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Fixed by replacing sprintf to snprintf.
>>
>> Fixes: 8860fd7b70f0 ("net/mrvl: add ingress policer support")
>> Cc: tdu@semihalf.com
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

> Acked-by: Tomasz Duszynski <tdu@semihalf.com>

Squashed into relevant commit in next-net, thanks.