From mboxrd@z Thu Jan  1 00:00:00 1970
From: Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [PATCH v3 02/15] eal/soc: add
 rte_eal_soc_register/unregister logic
Date: Fri, 16 Sep 2016 10:32:17 +0300
Message-ID: <a2ac469c-4d43-510d-1900-8720d2efe6b8@redhat.com>
References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com>
 <84c34eed-b2cb-5cbe-883c-dbbe3741e35f@intel.com>
 <20160915150930.6e381c85@pcviktorin.fit.vutbr.cz> <5302721.bs0Wxs4nOl@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, hemant.agrawal@nxp.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Jan Viktorin <viktorin@rehivetech.com>, "Hunt, David"
 <david.hunt@intel.com>, Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 9173F2C0A
 for <dev@dpdk.org>; Fri, 16 Sep 2016 09:32:21 +0200 (CEST)
In-Reply-To: <5302721.bs0Wxs4nOl@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/15/2016 05:09 PM, Thomas Monjalon wrote:
> 2016-09-15 15:09, Jan Viktorin:
>> On Thu, 15 Sep 2016 14:00:25 +0100
>> "Hunt, David" <david.hunt@intel.com> wrote:
>>
>>>> new file mode 100644
>>>> index 0000000..56135ed
>>>> --- /dev/null
>>>> +++ b/lib/librte_eal/common/eal_common_soc.c
>>>> @@ -0,0 +1,56 @@
>>>> +/*-
>>>> + *   BSD LICENSE
>>>> + *
>>>> + *   Copyright(c) 2016 RehiveTech. All rights reserved.
>>>> + *   All rights reserved.
>>>
>>> Duplicate "All rights reserved"
>>
>> This is present in many source files in DPDK... I don't know why.
>>
>> lib/librte_eal/common/eal_common_pci.c
>> lib/librte_eal/common/eal_common_dev.c
>> ...
>
> It would deserve a dedicated thread to discuss legal sense of these things.
> I'm not a lawyer but I think "All rights reserved." has no real sense.
>

 From a layman (such as myself) perspective it indeed seems totally 
ludicrous in the context of this particular license :) Whether it makes 
more sense to lawyers I wouldn't know, but as for the background: it's 
present in both 2- and 3-clause BSD licenses so *one* of them is 
probably best left alone.

According to https://fedoraproject.org/wiki/Licensing:BSD, in the 
3-clause BSD license "All rights reserved" is on a line of its own. In 
the other variants it follows the copyright holder. So that's probably 
where the duplicates originate from.

	- Panu -