From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7] ethdev: check Rx/Tx offloads
Date: Fri, 4 May 2018 15:45:23 +0100
Message-ID: <a31b21a7-0b46-80ec-d8df-fa5d6b95ef5b@intel.com>
References: <1525311040-26694-1-git-send-email-wei.dai@intel.com>
 <1525442529-12723-1-git-send-email-wei.dai@intel.com>
 <aad8d06a-b6cb-f7e4-902c-8bce7dfff656@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>
To: Wei Dai <wei.dai@intel.com>, thomas@monjalon.net
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id A3F0B2952
 for <dev@dpdk.org>; Fri,  4 May 2018 16:45:26 +0200 (CEST)
In-Reply-To: <aad8d06a-b6cb-f7e4-902c-8bce7dfff656@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/4/2018 3:42 PM, Ferruh Yigit wrote:
> On 5/4/2018 3:02 PM, Wei Dai wrote:
>> This patch check if a input requested offloading is valid or not.
>> Any reuqested offloading must be supported in the device capabilities.
>> Any offloading is disabled by default if it is not set in the parameter
>> dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and
>> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ).
>> From application, a pure per-port offloading can't be enabled on
>> any queue if it hasn't been enabled in rte_eth_dev_configure( ).
>> If any offloading is enabled in rte_eth_dev_configure( ) by application,
>> it is enabled on all queues no matter whether it is per-queue or
>> per-port type and no matter whether it is set or cleared in
>> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ).
>> The underlying PMD must be aware that the requested offloadings
>> to PMD specific queue_setup( ) function only carries those
>> offloadings only enabled for the queue but not enabled in
>> rte_eth_dev_configure( ) and they are certain per-queue type.
>>
>> This patch can make above such checking in a common way in rte_ethdev
>> layer to avoid same checking in underlying PMD.
>>
>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> 
> As mentioned in prev version, getting only this patch breaks the applications
> because of existing checks in the PMDs.
> 
> Hi Wei,
> 
> If you have bandwidth, can you update PMDs to remove their existing offload
> checks in this patch?
> 
> 
> PMDs needs to be updated for:
> 1- Remove existing offload verify checks
> 2- Update offload configure logic based on new values
> 
> (1) can be part of this patch. But PMD maintainers should send update for (2) if
> a change required.

cc'ed Shahaf, specially for (2) one.