From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v14] ethdev: new Rx/Tx offloads API
Date: Mon, 14 May 2018 15:46:38 +0100
Message-ID: <a3733305-5af6-4d1b-e903-197736b6c20f@intel.com>
References: <1526299235-54090-1-git-send-email-wei.dai@intel.com>
 <1526304030-15507-1-git-send-email-wei.dai@intel.com>
 <1833263.kcaJZ8Err9@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Wei Dai <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 4F6B71C8BF
 for <dev@dpdk.org>; Mon, 14 May 2018 16:46:40 +0200 (CEST)
In-Reply-To: <1833263.kcaJZ8Err9@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/14/2018 3:11 PM, Thomas Monjalon wrote:
> 14/05/2018 15:20, Wei Dai:
>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> [...]
>>   *   hasn't been set in the input argument eth_conf->rxmode.offloads
>>   *   to rte_eth_dev_configure(), it is a new added offloading, it must be
>>   *   per-queue type and it is enabled for the queue.
>> + *   No need to repeat any bit in rx_conf->offloads which has already been
>> + *   enabled in rte_eth_dev_configure() at port level. An offloading enabled
>> + *   at port level can't be disabled at queue level.
> 
> OK
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Squashed into relevant commit in next-net, thanks.

> 
> Thanks a lot Wei!
> 
>