From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radu Nicolau <radu.nicolau@intel.com>
Subject: Re: [PATCH 2/3] net/ixgbe: fix build issue
Date: Thu, 26 Oct 2017 13:30:48 +0100
Message-ID: <a3e6a4e2-d1b3-cdaf-ddfd-96f4b62719b3@intel.com>
References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com>
 <1509013365-13819-3-git-send-email-radu.nicolau@intel.com>
 <CALwxeUsOAA8KOtSLT0RqNNRa3UW4s=g9ddDKkFEAyRijQbVkLQ@mail.gmail.com>
 <36c6304e-cd1b-9bd9-2c5d-c6e20eff85e8@intel.com>
 <2601191342CEEE43887BDE71AB9772585FAAF5A7@IRSMSX103.ger.corp.intel.com>
 <CALwxeUtHVTPO5fJcLdmJjkCT9_n5iDhOFZxKfRh-nn5MfW1=Gw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan"
 <declan.doherty@intel.com>,
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 "borisp@mellanox.com" <borisp@mellanox.com>,
 "aviadye@mellanox.com" <aviadye@mellanox.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 "sandeep.malik@nxp.com" <sandeep.malik@nxp.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>,
 "shahafs@mellanox.com" <shahafs@mellanox.com>,
 Olivier Matz <olivier.matz@6wind.com>, Akhil Goyal <akhil.goyal@nxp.com>
To: David Marchand <david.marchand@6wind.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id B599C1BA4B
 for <dev@dpdk.org>; Thu, 26 Oct 2017 14:30:53 +0200 (CEST)
In-Reply-To: <CALwxeUtHVTPO5fJcLdmJjkCT9_n5iDhOFZxKfRh-nn5MfW1=Gw@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 10/26/2017 12:39 PM, David Marchand wrote:
> On Thu, Oct 26, 2017 at 1:30 PM, Ananyev, Konstantin
> <konstantin.ananyev@intel.com> wrote:
>>> -----Original Message-----
>>> From: Nicolau, Radu
>>> It can be disabled in the code, but as far as I know there is a general
>>> push back against having conditionally compiled code. I originally had
>>> the security sections in ixgbe PMD isolated, but the feedback was to
>>> have them always on.
>>> An alternative solution will be to remove the option altogether and
>>> always build rte_security library.
>> My vote would be to have it a mandatory library for ixgbe.
>> Add it into DEPDIRS-ixgbe inside drivers/net/Makefile or so.
> And then librte_security needs librte_crypto (if I am not mistaken).
> So if we go this way, we must ensure the same is done in librte_security.
>
>
It is already there: DEPDIRS-librte_security += librte_cryptodev