From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDA7C79FB9 for ; Thu, 10 Sep 2026 12:54:41 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FE6742D3F; Thu, 10 Sep 2026 14:53:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 570B742D26 for ; Thu, 10 Sep 2026 14:53:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789044818; x=1820580818; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ovCSRWNG5S+b1IUDTO7DTveBNbqGHIjaVnLNYA+9IvY=; b=CM0SG2AD2Ku1sWFPcsW87F++lTEfab7jJFjq6rt4Bgns1FG+BxJSf+F6 XZZEHSn/odrPrP/BFhPpMylOOKK8k4Mk/cu3TLAtWAYmYF3q2PGUrRJrM +VvUe4TLLon9LPgCGfKIFGRIgJVJiYHwvMPa2HoWbvzkO1u9ys8md2PXw yRrQAHJnwRNlA27g9y9xZXvbyYxSl7MVPhkx/YLEkw/rfg5ViLGJtK5L0 zs6nAOJEVz/vNQKOLHEjjnwV4/s737kDw0eP+AHC2gq0JkAEtzDZIPaGM c0LdYlhXk2qtuNqvZ6GwPBFbNctdrhQ6H6ys/v5evp969ICvhfZf//nQc A==; X-CSE-ConnectionGUID: 7rc57qL8SqyH1js38N5F6Q== X-CSE-MsgGUID: +eMRcYkWSGuZ0tQ8WRHE1g== X-IronPort-AV: E=McAfee;i="6800,10657,11900"; a="89334061" X-IronPort-AV: E=Sophos;i="6.27,95,1787036400"; d="scan'208";a="89334061" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2026 05:53:37 -0700 X-CSE-ConnectionGUID: HNGzr1WgQ96i+DETmEGcJw== X-CSE-MsgGUID: kHlvogCgQNSt9DXq9IfNjA== X-ExtLoop1: 1 Received: from silpixa00401119.ir.intel.com ([10.20.224.206]) by fmviesa003.fm.intel.com with ESMTP; 10 Sep 2026 05:53:37 -0700 From: Anatoly Burakov To: dev@dpdk.org, Bruce Richardson Subject: [PATCH v17 11/26] vfio: add container device assignment API Date: Thu, 10 Sep 2026 13:52:55 +0100 Message-ID: X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently, VFIO has explicit group bind API's, but the way they're used is such that no one actually cares about VFIO groups, and the real goal of everyone using VFIO group bind API is to bind devices to particular VFIO container, such that when `dev_vfio_setup_device` call eventually comes, VFIO will pick up the correct container. To remove dependency on group API's, add a new "container assign device" API call that will do the same thing, but will not depend on managing VFIO group fd's. Signed-off-by: Anatoly Burakov --- lib/eal/freebsd/eal.c | 10 ++++++++++ lib/eal/include/dev_vfio.h | 26 ++++++++++++++++++++++++++ lib/eal/linux/eal_vfio.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index b2d902f060..31340bb49a 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -965,3 +965,13 @@ dev_vfio_get_device_info(__rte_unused int vfio_dev_fd, rte_errno = ENOTSUP; return -1; } + +RTE_EXPORT_INTERNAL_SYMBOL(dev_vfio_container_assign_device) +int +dev_vfio_container_assign_device(__rte_unused int vfio_container_fd, + __rte_unused const char *sysfs_base, + __rte_unused const char *dev_addr) +{ + rte_errno = ENOTSUP; + return -1; +} diff --git a/lib/eal/include/dev_vfio.h b/lib/eal/include/dev_vfio.h index 099a35aa0e..eb8697e75c 100644 --- a/lib/eal/include/dev_vfio.h +++ b/lib/eal/include/dev_vfio.h @@ -277,6 +277,32 @@ __rte_internal int dev_vfio_container_destroy(int container_fd); +/** + * @internal + * + * Assign a device to a VFIO container. + * + * Doing so will cause `dev_vfio_setup_device()` call to set up the device with + * the VFIO container specified in this assign operation. + * + * This function is only relevant on Linux. + * + * @param vfio_container_fd + * VFIO container file descriptor. + * @param sysfs_base + * Sysfs path prefix. + * @param dev_addr + * Device identifier. + * + * @return + * 0 on success. + * <0 on failure. + */ +__rte_internal +int +dev_vfio_container_assign_device(int vfio_container_fd, const char *sysfs_base, + const char *dev_addr); + /** * @internal * Bind a IOMMU group to a container. diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c index 0a7e3e9c9b..ae53d95de5 100644 --- a/lib/eal/linux/eal_vfio.c +++ b/lib/eal/linux/eal_vfio.c @@ -2161,6 +2161,38 @@ dev_vfio_container_destroy(int container_fd) return 0; } +RTE_EXPORT_INTERNAL_SYMBOL(dev_vfio_container_assign_device) +int +dev_vfio_container_assign_device(int vfio_container_fd, const char *sysfs_base, + const char *dev_addr) +{ + int iommu_group_num; + int ret; + + ret = dev_vfio_get_group_num(sysfs_base, dev_addr, &iommu_group_num); + if (ret < 0) { + EAL_LOG(ERR, "Cannot get IOMMU group number for device %s", + dev_addr); + return -1; + } else if (ret == 0) { + EAL_LOG(ERR, + "Device %s is not assigned to any IOMMU group", + dev_addr); + return -1; + } + + ret = dev_vfio_container_group_bind(vfio_container_fd, + iommu_group_num); + if (ret < 0) { + EAL_LOG(ERR, + "Cannot bind IOMMU group %d for device %s", + iommu_group_num, dev_addr); + return -1; + } + + return 0; +} + RTE_EXPORT_INTERNAL_SYMBOL(dev_vfio_container_group_bind) int dev_vfio_container_group_bind(int container_fd, int iommu_group_num) -- 2.52.0