From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH 1/2] eal/thread: fix return codes for
 rte_thread_setname()
Date: Mon, 18 Jun 2018 11:00:55 +0100
Message-ID: <a41161f6-4f13-4225-ccd5-91badb92c646@intel.com>
References: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: thomas.monjalon@6wind.com, stable@dpdk.org
To: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote:
> The doc says this function returns negative errno
> on error, but it currently returns either -1 or
> positive errno.
> 
> It was incorrectly assumed that pthread_setname_np()
> returns negative error numbers. It always returns
> positive ones, so this patch negates its return value
> before returning.
> 
> While here, also ignore rte_thread_setname() failure
> in rte_ctrl_thread_create() and print a debug message
> instead.
> 
> Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD")
> Cc: thomas.monjalon@6wind.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> ---

For patch contents,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

However, maybe this should be split in two patches.

-- 
Thanks,
Anatoly