From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [PATCH v3 3/3] doc: update build-sdk-quick txt file Date: Wed, 11 Apr 2018 09:44:07 +0100 Message-ID: References: <1495788764-37652-2-git-send-email-david.hunt@intel.com> <1709610.YWM5RO7iyE@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, "shreyansh.jain@nxp.com" To: Thomas Monjalon , Ferruh Yigit , "Mcnamara, John" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A5BC51B7A0 for ; Wed, 11 Apr 2018 10:43:26 +0200 (CEST) In-Reply-To: <1709610.YWM5RO7iyE@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas On 13/2/2018 11:41 PM, Thomas Monjalon wrote: > 13/02/2018 13:18, Ferruh Yigit: >> On 6/12/2017 1:50 PM, Mcnamara, John wrote: >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt >>>> Sent: Wednesday, June 7, 2017 3:38 PM >>>> To: dev@dpdk.org >>>> Cc: thomas@monjalon.net; shreyansh.jain@nxp.com; Hunt, David >>>> >>>> Subject: [dpdk-dev] [PATCH v3 3/3] doc: update build-sdk-quick txt file >>>> >>>> * Add in information about 'make defconfig' >>>> * Add in information about RTE_TEMPLATE environment variable >>>> * Explain the default directory for 'O=' a bit better >>>> * Clean up text alignment >>>> >>>> Signed-off-by: David Hunt >>> Acked-by: John McNamara >> Acked-by: Ferruh Yigit > I made some comments in patch 2 about RTE_TEMPLATE and got no reply > (in August). Since you correctly point out that "make install T=" is an old syntax, and this variable only encourages this, let's drop this patch altogether. There are two patches in patchwork relevant to this cahange, one is the change, and the other is the docs update. There was a third part, which was for the "make defconfig" functionality, which has already been merged, including a portion of 25113, so both of the following can be closed off. http://dpdk.org/dev/patchwork/patch/25112/ http://dpdk.org/dev/patchwork/patch/25113/ > This patch is dependent on RTE_TEMPLATE. > > One more nit: the indent is broken for T variable explanation.