From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] net/mlx4: fix flow creation before start Date: Mon, 31 Jul 2017 17:48:29 +0100 Message-ID: References: <20170726093401.GU19852@6wind.com> <1501151244-2917-1-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, stable@dpdk.org To: Matan Azrad , Adrien Mazarguil Return-path: In-Reply-To: <1501151244-2917-1-git-send-email-matan@mellanox.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/27/2017 11:27 AM, Matan Azrad wrote: > The corrupted code causes segmentation fault when user creates > flow with drop action before device starting. > > For example, failsafe PMD recreates all the flows before calling > dev_start in plug-in sequence and mlx4 allocated its flow drop > queue in dev_start. > Hence, when failsafe created flow with drop action after plug-in > event, mlx4 tried to dereference flow drop queue which was uninitialized. > > The fix added check to the drop qp accesibale and conditioned the > ibv_create_flow calling on device starting. > > Fixes: 642fe56a1ba5 ("net/mlx4: use a single drop queue for all drop flows") > Fixes: 46d5736a7049 ("net/mlx4: support basic flow items and actions") > Cc: stable@dpdk.org > > Signed-off-by: Matan Azrad > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.