From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 1/2] net/pcap: multiple queues fix
Date: Wed, 20 Jun 2018 19:22:19 +0100
Message-ID: <a4b4c2a9-26ea-d8ce-dcf0-05b3fb0ca5eb@intel.com>
References: <1529419046-95906-1-git-send-email-ido@cgstowernetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, stable@dpdk.org
To: ido goshen <ido@cgstowernetworks.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1529419046-95906-1-git-send-email-ido@cgstowernetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/19/2018 3:37 PM, ido goshen wrote:
> Fixes: 4c173302c307 ("pcap: add new driver")
> Cc: stable@dpdk.org
> 
> Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper
> and not loop num_of_queue times
> The num_of_queue loop is already acheived by the caller rte_kvargs_process
> 
> Fixes:
> 1. Opens N requested pcaps/dumpers instead of N^2
> 2. Leak of pcap/dumper's which are being overwritten by
>    the sequential calls to open_rx/tx_pcap/iface functions
> 3. Use the filename/iface args per queue and not just the last one
>    that overwrites the previous names
> 
> Signed-off-by: ido goshen <ido@cgstowernetworks.com>

For series,
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>