From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] net/af_packet: make bypass configurable
Date: Thu, 21 Sep 2017 10:34:36 +0100
Message-ID: <a4e22af5-eb4f-e8db-c7c1-b50bd7fe497f@intel.com>
References: <20170919212131.7006-1-3chas3@gmail.com>
 <20170921032536.4461-1-3chas3@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: linville@tuxdriver.com, "Charles (Chas) Williams" <ciwillia@brocade.com>,
 Chas Williams <chas3@att.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 0DC3D1B194
 for <dev@dpdk.org>; Thu, 21 Sep 2017 11:34:54 +0200 (CEST)
In-Reply-To: <20170921032536.4461-1-3chas3@gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/21/2017 4:25 AM, Chas Williams wrote:
> From: "Charles (Chas) Williams" <ciwillia@brocade.com>
> 
> In certain situations, low speed interfaces, it may be desirable to
> have the flow control provided by the kernel queueing disciplines.
> 
> Signed-off-by: Chas Williams <chas3@att.com>
> ---
>  drivers/net/af_packet/rte_eth_af_packet.c | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
> index 7aa26e5..b95d87d 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -59,6 +59,7 @@
>  #define ETH_AF_PACKET_BLOCKSIZE_ARG	"blocksz"
>  #define ETH_AF_PACKET_FRAMESIZE_ARG	"framesz"
>  #define ETH_AF_PACKET_FRAMECOUNT_ARG	"framecnt"
> +#define ETH_AF_PACKET_BYPASS_ARG	"qdisc_bypass"
>  
>  #define DFLT_BLOCK_SIZE		(1 << 12)
>  #define DFLT_FRAME_SIZE		(1 << 11)
> @@ -115,6 +116,7 @@ static const char *valid_arguments[] = {
>  	ETH_AF_PACKET_BLOCKSIZE_ARG,
>  	ETH_AF_PACKET_FRAMESIZE_ARG,
>  	ETH_AF_PACKET_FRAMECOUNT_ARG,
> +	ETH_AF_PACKET_BYPASS_ARG,

There was a comment about the define name, just to double check if this
has been missed or intentional.

<...>