From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v5 1/2] net/tap: calculate checksums of multi segs packets Date: Wed, 27 Jun 2018 14:11:31 +0100 Message-ID: References: <1528821108-12405-3-git-send-email-ophirmu@mellanox.com> <1529795861-1361-1-git-send-email-ophirmu@mellanox.com> <1529795861-1361-2-git-send-email-ophirmu@mellanox.com> <69DA085D-92D8-459F-BEAC-DCB807C8985B@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" , Thomas Monjalon , Olga Shern To: "Wiles, Keith" , Ophir Munk Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9F51E1BB2F for ; Wed, 27 Jun 2018 15:11:36 +0200 (CEST) In-Reply-To: <69DA085D-92D8-459F-BEAC-DCB807C8985B@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/24/2018 2:45 PM, Wiles, Keith wrote: > > >> On Jun 23, 2018, at 6:17 PM, Ophir Munk wrote: >> >> Prior to this commit IP/UDP/TCP checksum offload calculations >> were skipped in case of a multi segments packet. >> This commit enables TAP checksum calculations for multi segments >> packets. >> The only restriction is that the first segment must contain >> headers of layers 3 (IP) and 4 (UDP or TCP) >> >> Reviewed-by: Raslan Darawsheh >> Signed-off-by: Ophir Munk >> — > > Looks good. Still could have had a few more blank lines IMHO :-) > > Acked-by: Keith Wiles for Series Series applied to dpdk-next-net/master, thanks.