From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v7 2/2] examples/vdpa: introduce a new sample
	for vDPA
Date: Fri, 28 Sep 2018 10:31:34 +0200
Message-ID: <a69fcc6b-ae4f-b0c7-33ea-ecbf3daa2fac@redhat.com>
References: <20180926090638.4705-1-xiaolong.ye@intel.com>
 <20180928112344.42791-1-xiaolong.ye@intel.com>
 <20180928112344.42791-3-xiaolong.ye@intel.com>
 <e1452c00-6fd8-89a1-0722-f77cf4893650@redhat.com>
 <20180928143353.GA44187@intel.com>
 <af8317de-e91f-3f27-2aa8-b69ed0311618@redhat.com>
 <20180928151733.GA44818@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
 Zhihong Wang <zhihong.wang@intel.com>, xiao.w.wang@intel.com,
 Rami Rosen <roszenrami@gmail.com>, Wang Haiyue <haiyue.wang@intel.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 029A91B108
 for <dev@dpdk.org>; Fri, 28 Sep 2018 10:31:39 +0200 (CEST)
In-Reply-To: <20180928151733.GA44818@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 09/28/2018 05:17 PM, Ye Xiaolong wrote:
> On 09/28, Maxime Coquelin wrote:
>>
>>
>> On 09/28/2018 04:33 PM, Ye Xiaolong wrote:
>>> On 09/28, Maxime Coquelin wrote:
>>>>> +	ret = rte_eal_init(argc, argv);
>>>>> +	if (ret < 0)
>>>>> +		rte_exit(EXIT_FAILURE, "eal init failed\n");
>>>>> +	argc -= ret;
>>>>> +	argv += ret;
>>>>> +
>>>>> +	data_init();
>>>>
>>>> You need to check return from data_init().
>>>> If this is fine for you, I can change to below code when applying:
>>>>
>>>> ret = data_init();
>>>> if (ret < 0)
>>>>      rte_exit(EXIT_FAILURE, "data init failed\n");
>>>>
>>>>
>>>
>>> I'm fine with this change.
>>
>> Or even better, get rid of data_init and
>> call rte_vdpa_get_device_num(); in main directly.
> 
> Sounds better, as we've removed unnecessary static variable initialization in
> data_init, it does nothing but call rte_vdpa_get_device_num, we can remove this
> wrap. Would you do this change when applying or you perfer I send a new
> revision?

Please send a new revision, and in the commit message,
fix first letter of my family name with an upper case,
and move my R-b below your sign-off.

Thanks!
Maxime

> Thanks,
> Xiaolong
> 
> 
>>
>>> Thanks,
>>> Xiaolong
>>>