From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] doc: add a user guidance document for igb
Date: Thu, 8 Feb 2018 12:30:44 +0000
Message-ID: <a6a1a99c-d964-d4f7-ab57-a149a747e71f@intel.com>
References: <20180131084710.133820-1-wei.zhao1@intel.com>
 <20180202032932.13752-1-wei.zhao1@intel.com>
 <e1bad2ff-8849-aabf-3bf7-8dc648f7469a@intel.com>
 <B27915DBBA3421428155699D51E4CFE23EEAB97E@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: "Mcnamara, John" <john.mcnamara@intel.com>,
 "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 718661B7CB
 for <dev@dpdk.org>; Thu,  8 Feb 2018 13:30:54 +0100 (CET)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23EEAB97E@IRSMSX103.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/8/2018 12:27 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Thursday, February 8, 2018 11:39 AM
>> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
>> Cc: Mcnamara, John <john.mcnamara@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for
>> igb
>>
>> On 2/2/2018 3:29 AM, Wei Zhao wrote:
>>> This patch add a user guidance document specific for igb nic.
>>> By now, a doc like ixgbe.rst is also needed by igb nic. So this patch
>>> add igb.rst to record important information about igb, like feature
>>> supported and known issues.
>>>
>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>>
>>> ---
>>>
>>> v2:
>>> -change code indentation style.
>>>
>>> v3:
>>> -add more details for igb feature.
>>> ---
>>>  doc/guides/nics/igb.rst | 38 ++++++++++++++++++++++++++++++++++++++
>>
>> This file is not in the index, so you won't able select file from side bar
>> and will be very hard to access this document unless you know the url,
>> also producing a warning for same thing:
>>
>> .../doc/guides/nics/igb.rst: WARNING: document isn't included in any
>> toctree
> 
> 
> I missed that in the review. Can you fix that in the merge?

I can, let me do it.

> 
> John
>