From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 08/18] net/axgbe: add transmit and receive
 queue setup apis
Date: Fri, 16 Mar 2018 17:44:34 +0000
Message-ID: <a6b854ca-24cb-80a0-8ef3-af5395e19e7e@intel.com>
References: <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com>
 <1520584954-130575-1-git-send-email-Ravi1.kumar@amd.com>
 <1520584954-130575-8-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 405777CDA
 for <dev@dpdk.org>; Fri, 16 Mar 2018 18:44:36 +0100 (CET)
In-Reply-To: <1520584954-130575-8-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/9/2018 8:42 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

<...>

> +
> +	rxq->crc_len = (uint8_t)((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0 :
> +				 ETHER_CRC_LEN);

This is also changed recently, new ethdev offloading API introduced which PMDs
target to switch this release.

According new offloading API, instead of using
dev->data->dev_conf.rxmode.hw_strip_crc, (dev->data->dev_conf.rxmode.offloads &
DEV_RX_OFFLOAD_CRC_STRIP) should be checked.

<...>