From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: vf init issue with patch igb_uio: issue FLR during
 open and release of device file
Date: Fri, 15 Sep 2017 10:25:44 +0100
Message-ID: <a6be0c0c-705e-33aa-558f-e114e663caec@intel.com>
References: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com>
 <D5DED7B9.160793%Harish.Patil@cavium.com>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA3EB@SHSMSX151.ccr.corp.intel.com>
 <1836615.UbEDzhAzGh@xps>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA492@SHSMSX151.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Tan, Jianfeng" <jianfeng.tan@intel.com>,
 "Thotton, Shijith" <Shijith.Thotton@cavium.com>,
 "Hu, Xuekun" <xuekun.hu@intel.com>, "Patil, Harish"
 <Harish.Patil@cavium.com>, Gregory Etelson <gregory@weka.io>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Yang, Qiming" <qiming.yang@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7EA492@SHSMSX151.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/15/2017 10:18 AM, Yang, Qiming wrote:
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> Sent: Friday, September 15, 2017 4:43 PM
>> To: Yang, Qiming <qiming.yang@intel.com>
>> Cc: dev@dpdk.org; Tan, Jianfeng <jianfeng.tan@intel.com>; Thotton, Shijith
>> <Shijith.Thotton@cavium.com>; Hu, Xuekun <xuekun.hu@intel.com>; Yigit,
>> Ferruh <ferruh.yigit@intel.com>; Patil, Harish <Harish.Patil@cavium.com>;
>> Gregory Etelson <gregory@weka.io>; stable@dpdk.org
>> Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open
>> and release of device file
>>
>> Hi
>>
>> 15/09/2017 10:04, Yang, Qiming:
>>> Hi, Thomas
>>> We meet a urgent issue because of Shijith's patch.
>>> When use DPDK version 17.08, DPDK VF driver and kernel PF driver, i40e, ixgbe
>> and qede(Harish said) VF all meet initial failure.
>>
>> This patch has been integrated in DPDK 17.08-rc2 (2 months ago).
>> Why a so obvious issue is discovered only now?
>>
>>> This issue only occurred when use 17.08 igb_uio, vfio-pci and 17.05 igb_uio all
>> works well.
>>> Considering this issue will block our vf driver develop and test work, could we
>> revert this patch first and find another appropriate way?
>>
>> We need to be sure the revert is the right solution because it will be backported
>> to the stable 17.08 release.
>>
>> Shijith suggests to "try removing pci_reset_function from igbuio_pci_open."
>> Can we try this first?
>> Are we sure the bug is not in new firmwares?
> 
> I have tried to remove pci_reset_function, it works in my environment, but it doesn't work in someone's enviroment.
> And removing this function won't it changes the original purpose of his patch?  So I'm not sure it is a good solution.

Yes, removing that will be functionally almost same with revert.

> This bug is not a firmware version related issue, we can reproduce stably with older firmware.

I also think this is not related to the firmware.
But I don't see why works with one version of the Linux PF driver, but
not other.

> 
> Qiming
>