From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] ethdev: make default behavior CRC strip
	on Rx
Date: Fri, 14 Sep 2018 12:37:28 +0100
Message-ID: <a7389432-1492-d836-5dcc-9919193b9c9c@intel.com>
References: <20180903144501.31373-1-ferruh.yigit@intel.com>
 <20180904101257.61129-1-ferruh.yigit@intel.com>
 <DB7PR05MB442643D0A61E46F2A9642223C3030@DB7PR05MB4426.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Shahaf Shuler <shahafs@mellanox.com>,
 Thomas Monjalon <thomasm@mellanox.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 3D1785323
 for <dev@dpdk.org>; Fri, 14 Sep 2018 13:37:31 +0200 (CEST)
In-Reply-To: <DB7PR05MB442643D0A61E46F2A9642223C3030@DB7PR05MB4426.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/4/2018 11:02 AM, Shahaf Shuler wrote:
> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit:
>> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx
>>
>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
>> Without any specific Rx offload flag, default behavior by PMDs is to
>> strip CRC.
>>
>> PMDs that support keeping CRC should advertise
>> DEV_RX_OFFLOAD_KEEP_CRC
>> Rx offload capability.
>>
>> Applications that require keeping CRC should check PMD capability first
>> and if it is supported can enable this feature by setting
>> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure()
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Acked-by: Tomasz Duszynski <tdu@semihalf.com>
>> ---
>> v2:
>> * fix flag check
>> * add KEEP_CRC flag into "show port cap #"
>>
>>   Note "show port cap #" and
>>   "show port # [r/t]x_offload capabilities/configuration"
>>   does same thing, in long term I suggest removing "show port cap" one
> 
> 
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> 

Applied to dpdk-next-net/master, thanks.