From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 1/7] net/bnxt: get rid of ff pools array and
 use the vnic info array
Date: Wed, 19 Sep 2018 10:05:39 +0100
Message-ID: <a7c70169-b8b4-ee9b-25d1-81caba1aaa33@intel.com>
References: <20180901043254.51000-1-ajit.khaparde@broadcom.com>
 <20180901043254.51000-2-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, stable@dpdk.org
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180901043254.51000-2-ajit.khaparde@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/1/2018 5:32 AM, Ajit Khaparde wrote:
> From: Somnath Kotur <somnath.kotur@broadcom.com>
> 
> There was no direct association between the rxq's vnic and the vnic_info[].
> Explicitly associate the two in bnxt_mq_rx_configure().
> 
> Fixes: f7c3d72afff7 ("net/bnxt: fix Rx ring count limitation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

<...>

>  void bnxt_free_vnic_attributes(struct bnxt *bp)
>  {
>  	struct bnxt_vnic_info *vnic;
> +	unsigned int i;
>  
> -	STAILQ_FOREACH(vnic, &bp->free_vnic_list, next) {
> +	for (i = 0; i < bp->nr_vnics; i++) {
>  		if (vnic->rss_table) {

Here vnic accessed without initial value [1], I guess intention was:
 "vnic = &bp->vnic_info[i];" before access.

[1]
.../drivers/net/bnxt/bnxt_vnic.c:93:7: error: variable 'vnic' is uninitialized
when used here [-Werror,-Wuninitialized]
                if (vnic->rss_table) {
                    ^~~~