From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH 2/5] examples/ethtool: add a new command module-eeprom Date: Tue, 13 Mar 2018 14:46:34 +0000 Message-ID: References: <1520828243-25191-1-git-send-email-zijie.pan@6wind.com> <1520828243-25191-3-git-send-email-zijie.pan@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Zijie Pan To: dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BA6BAA491 for ; Tue, 13 Mar 2018 15:46:37 +0100 (CET) In-Reply-To: <1520828243-25191-3-git-send-email-zijie.pan@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Comments inline. On the whole looks good to me. On 12/03/2018 04:17, Zijie Pan wrote: [..] > Signed-off-by: Zijie Pan > --- > doc/guides/sample_app_ug/ethtool.rst | 2 ++ > examples/ethtool/ethtool-app/ethapp.c | 61 +++++++++++++++++++++++++++++++++ > examples/ethtool/lib/rte_ethtool.c | 30 ++++++++++++++++ > examples/ethtool/lib/rte_ethtool.h | 34 ++++++++++++++++++ > 4 files changed, 127 insertions(+) Reviewed-by: Remy Horton > cmdline_parse_token_string_t pcmd_eeprom_token_cmd = > TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "eeprom"); > +cmdline_parse_token_string_t pcmd_module_eeprom_token_cmd = > + TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "module-eeprom"); Checkpatch: 80 character limit. > + info_eeprom.len = module_info[1]; > + info_eeprom.offset = 0; > + stat = rte_ethtool_get_module_eeprom(params->port, > + &info_eeprom, bytes_eeprom); > + if (stat != 0 || module_info[1] <= 0) { This supposed to be module_info[1] rather than info_eeprom.len ?