From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v3 1/2] ethdev: introduce Rx queue offloads
	API
Date: Wed, 13 Sep 2017 15:34:51 +0300
Message-ID: <a87e92b8-23f7-fc9f-e6d9-d7bfa7096dfd@solarflare.com>
References: <cover.1505044395.git.shahafs@mellanox.com>
 <cover.1505284270.git.shahafs@mellanox.com>
 <dcf25792cdb0da6e9a0b412f97786151fe571b88.1505284270.git.shahafs@mellanox.com>
 <223be6bf-510e-e34d-2359-c0f1becd5bad@solarflare.com>
 <07f35197-ed1c-a959-3518-3a541e259b3c@solarflare.com>
 <VI1PR05MB31495169413A2DACD460826CC36E0@VI1PR05MB3149.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Shahaf Shuler <shahafs@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id D96237CBD
 for <dev@dpdk.org>; Wed, 13 Sep 2017 14:35:04 +0200 (CEST)
In-Reply-To: <VI1PR05MB31495169413A2DACD460826CC36E0@VI1PR05MB3149.eurprd05.prod.outlook.com>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 09/13/2017 03:33 PM, Shahaf Shuler wrote:
>
> Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko:
>
>         >>return -EBUSY;
>         >>      }
>         >>  +    /*
>         >>+     * Convert between the offloads API to enable PMDs to
>         support
>         >>+     * only one of them.
>         >>+     */
>         >>+    if ((dev_conf->rxmode.ignore_offload_bitfield == 0)) {
>         >>+ rte_eth_convert_rx_offload_bitfield(
>         >>+ &dev_conf->rxmode, &local_conf.rxmode.offloads);
>         >>+    } else {
>         >>+ rte_eth_convert_rx_offloads(dev_conf->rxmode.offloads,
>         >>+ &local_conf.rxmode);
>
>
>     >Ignore flag is lost here and it will result in treating txq_flags
>     as the primary
>     >information about offloads. It is important in the case of
>     failsafe PMD.
>
> >
> >Sorry, I mean rxmode (not txq_flags).
>
> Am not sure the ignore_offload_bitfield is lost on converstion. The 
> convert function does not assign to it.
>

That's true. My bad.