From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v9 22/25] eal/pci: inherit rte_driver by
 rte_pci_driver
Date: Thu, 8 Sep 2016 15:25:41 +0100
Message-ID: <a8ff6647-c082-e589-4418-8833318bd0c7@intel.com>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
 <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com>
 <1473257297-7221-23-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: hemant.agrawal@nxp.com, Jan Viktorin <viktorin@rehivetech.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 87FCFCE7
 for <dev@dpdk.org>; Thu,  8 Sep 2016 16:25:43 +0200 (CEST)
In-Reply-To: <1473257297-7221-23-git-send-email-shreyansh.jain@nxp.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/7/2016 3:08 PM, Shreyansh Jain wrote:
> Remove the 'name' member from rte_pci_driver and move to generic rte_driver.
> 
> Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(<name>..)
> as well as assigning a name to eth_driver.pci_drv.name member.
> In this patch, only the original DRIVER_REGISTER_PCI(<name>..) name has been
> populated into the rte_driver.name member - assignments through eth_driver
> has been removed.
> 
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

...

> diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> index c0bd391..b8bfd4b 100644
> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> @@ -172,4 +172,7 @@ DPDK_16.11 {
>  
>  	rte_eal_dev_attach;
>  	rte_eal_dev_detach;
> +	rte_eal_vdrv_register;
> +	rte_eal_vdrv_unregister;
> +
>  } DPDK_16.07;

This needs to be part of patch 15, where these functions implemented.

Missing these in .map files cause patch 17,18,19,20,21 fail to compile
for shared lib config.