From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: [PATCH] ixgbe: fix build with gcc 5 Date: Thu, 19 Feb 2015 12:25:06 +0200 Message-ID: To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Add extra parenthesis to remove ambiguity on what we want to compare, otherwise gcc 5 issues a "logical not is only applied to the left hand side of comparison" warning which with -Werror fails the build. Signed-off-by: Panu Matilainen --- lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c index 37e5bae..93a6a00 100644 --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c @@ -2898,8 +2898,8 @@ STATIC s32 ixgbe_fc_autoneg_fiber(struct ixgbe_hw *hw) */ linkstat = IXGBE_READ_REG(hw, IXGBE_PCS1GLSTA); - if ((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE) == 0) || - (!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT) == 1)) { + if (((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE)) == 0) || + ((!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT)) == 1)) { ERROR_REPORT1(IXGBE_ERROR_POLLING, "Auto-Negotiation did not complete or timed out"); goto out; -- 2.1.0