From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v8 07/10] eal: replace rte_panic instances in
 hugepage_info
Date: Wed, 25 Apr 2018 15:14:25 +0100
Message-ID: <a9235539-4c31-f705-244c-e510d04b1d1b@intel.com>
References: <1524608213-2080-1-git-send-email-arnon@qwilt.com>
 <1524663944-30376-1-git-send-email-arnon@qwilt.com>
 <1524663944-30376-8-git-send-email-arnon@qwilt.com>
 <ebbf4ff8-76c4-6cde-d4b9-da334d7943f0@intel.com>
 <CAKy9EB36KhohQ0BKPeMnnG2gb-Wkmz8fRdJ1=X7WaOwiPno0Mg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson
 <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 dev@dpdk.org
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id CDC7F7CBA
 for <dev@dpdk.org>; Wed, 25 Apr 2018 16:14:28 +0200 (CEST)
In-Reply-To: <CAKy9EB36KhohQ0BKPeMnnG2gb-Wkmz8fRdJ1=X7WaOwiPno0Mg@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 25-Apr-18 3:02 PM, Arnon Warshavsky wrote:
> 
>     I think i've already acked this. You should keep acks etc. between
>     versions (unless you're making significant enough changes that you
>     think would invalidate a prior ack). Having acks makes it easier to
>     track what still needs to be reviewed and what is good to go, and it
>     makes it easier to see if the entire patchset is ready for apply.
> 
> 
> Hmm, so unless I am missing yet another thing - this needs to be done 
> manually?
> 

Yes. Well, if someone series-acks your patch, you can do "git 
filter-branch", but for individual patches, yes, you need to do this 
manually by editing the commit message.

-- 
Thanks,
Anatoly