From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] pci: fix configure device fail issue
Date: Wed, 8 Feb 2017 10:53:46 +0000
Message-ID: <a9339940-1fa6-b354-6972-b5792c48b257@intel.com>
References: <1486547416-63712-1-git-send-email-jia.guo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Jeff Guo <jia.guo@intel.com>, helin.zhang@intel.com, jingjing.wu@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 69CE9952
 for <dev@dpdk.org>; Wed,  8 Feb 2017 11:53:48 +0100 (CET)
In-Reply-To: <1486547416-63712-1-git-send-email-jia.guo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/8/2017 9:50 AM, Jeff Guo wrote:
> If assign the "data->dev_flags" after run function "rte_eth_copy_pci_info", the
> flag would be miss the “RTE_ETH_DEV_INTR_LSC” value, that will result the device
> configuration fail, when rte check the flag if device support link state interrupt.
> So the assignment must be modified to "|=" to fix the issue.
> 
> Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI devices")
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>

This is same as Qi's patch:
http://dpdk.org/dev/patchwork/patch/20163/

That one is earlier, but missing em driver, so I will use this patch
with sign-off from both of you. Please shout if you disagree.

Thanks,
ferruh