From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH] ethdev: fix statistics description Date: Thu, 3 Nov 2016 10:00:37 +0800 Message-ID: References: <1472206104-22035-1-git-send-email-wei.dai@intel.com> <2544827.v0ahXV4zxG@xps13> <49759EB36A64CF4892C1AFEC9231E8D63A2EB13C@PGSMSX106.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Mcnamara, John" , "Dai, Wei" , Thomas Monjalon , "Ananyev, Konstantin" , "Wu, Jingjing" , "Zhang, Helin" , "Curran, Greg" , "Van Haaren, Harry" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6010929C7 for ; Thu, 3 Nov 2016 03:00:42 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/11/2016 17:07, Mcnamara, John wrote: [..] > Perhaps we could an API that returns a struct, or otherwise, that > indicated what stats are returned by a PMD. An application that > required stats could call it once to establish what stats were > available. It would have to be done in some way that wouldn't break > ABI every time a new stat was added. > > Harry, Remy, how would this fit in with the existing stats scheme or > the new metrics library. At the moment xstats (rte_eth_xstats_get()) pulls stuff out of rte_eth_stats and reports them unconditionally alongside all the driver-specific xstats. This could change so that it only reports the (legacy) stats the PMDs actually fills in. Personally in the longer term I think xstats should get all the info it requires directly rather than relying on the legacy stats for some of its info, but that would involve pushing a lot of common code into the PMDs.. ..Remy