From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH 09/13] eal: replace rte_panic instances in common_memzone Date: Wed, 4 Apr 2018 13:09:25 +0100 Message-ID: References: <1522841257-11826-1-git-send-email-arnon@qwilt.com> <1522841257-11826-10-git-send-email-arnon@qwilt.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Arnon Warshavsky , thomas@monjalon.net, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A4B391C18C for ; Wed, 4 Apr 2018 14:09:29 +0200 (CEST) In-Reply-To: <1522841257-11826-10-git-send-email-arnon@qwilt.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04-Apr-18 12:27 PM, Arnon Warshavsky wrote: > replace panic calls with log and retrun value. > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_eal/common/eal_common_memzone.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c > index 1ab3ade..fa0a407 100644 > --- a/lib/librte_eal/common/eal_common_memzone.c > +++ b/lib/librte_eal/common/eal_common_memzone.c > @@ -314,8 +314,9 @@ > if (addr == NULL) > ret = -EINVAL; > else if (mcfg->memzone_cnt == 0) { > - rte_panic("%s(): memzone address not NULL but memzone_cnt is 0!\n", > - __func__); > + RTE_LOG(CRIT, EAL, "%s(): memzone address not NULL but memzone_cnt" > + " is 0!\n", __func__); > + return -1; > } else { > memset(&mcfg->memzone[idx], 0, sizeof(mcfg->memzone[idx])); > mcfg->memzone_cnt--; > This changes public API. For now, memzone docs mention either return value of 0, or return value of -EINVAL in case of invalid arguments: /** * Free a memzone. * * @param mz * A pointer to the memzone * @return * -EINVAL - invalid parameter. * 0 - success */ I'm not sure returning -EINVAL is suitable in this case (the parameter was valid, but an internal error happened - I can't think of any suitable errno value off hand), and adding a new return value changes API, which presumably would require a deprecation notice. Thomas? -- Thanks, Anatoly