From: Bruce Richardson <bruce.richardson@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>, <stephen@networkplumber.org>
Subject: Re: [PATCH 3/3] drivers: always enable the null net driver [RFC]
Date: Thu, 22 Jan 2026 14:59:21 +0000 [thread overview]
Message-ID: <aXI7STpuEtMWQloB@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F6568F@smartserver.smartshare.dk>
On Thu, Jan 22, 2026 at 02:40:45PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Thursday, 22 January 2026 14.32
> >
> > On Thu, Jan 22, 2026 at 02:13:06PM +0100, Morten Brørup wrote:
> > > > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > > > Sent: Thursday, 22 January 2026 13.24
> > > >
> > > > Having the net_null driver always available can be convenient and
> > > > allows
> > > > use by unit tests, so add this trivial driver to the always-enable
> > > > list.
> > > >
> > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > >
> > > > ---
> > > > I'm not sure if we want this to be always enabled or not, so
> > sending
> > > > this as an RFC. I can see definite advantages to doing so, but I
> > also
> > > > dislike having too many components on the always-enable list.
> > > >
> > > > Since I'm ambivilent myself, including this patch so the community
> > can
> > > > decide.
> > >
> > > I don't think real applications use this.
> > > If they do, they can include it manually.
> > >
> > > My main objection is:
> > > We are setting the wrong precedence if we make stuff like this
> > mandatory for convenience.
> > >
> > > But I agree with the reason you are suggesting it.
> > >
> > > Is there some other way it can be enabled for unit tests?
> > > Maybe the null driver can depend on the unit tests being built?
> > >
> > > I don't mind that the driver is being built.
> > > I just don't want it included by default when statically linking a
> > monolithic application.
> > >
> > > I'm flexible on this RFC, so it's a very soft NAK from me.
> > > If it can be disabled at build time, I'm OK with it. (But still
> > concerned about setting the wrong precedence.)
> > >
> > Yes, I agree.
> >
> > Why I'm proposing this is because, in order to give me faster rebuilds
> > and
> > because of the hardware I have available to me, I generally set up my
> > builds with "-Denable_drivers=net/intel/*", since that really speeds up
> > my
> > dev-build-test cycle. In doing so, though, I do miss out on having some
> > unit tests available when I run the fast-test suite, which is why I
> > suggested this addition in case there are others who limit the builds
> > to
> > just the hardware they are using.
>
> You can build with "-Denable_drivers=net/intel/*,net/null".
>
> Then I'll suggest an alternative to this patch:
> Change the fast-test application, so it emits an informational message about which tests are being skipped because the net/null driver is missing.
>
That is sadly non-trivial, and if we do so for net-null, we should also do
so for a bunch of other components where we disable tests if they are
missing. But the idea of just informing the user rather than force-enabling
the driver is a good one.
next prev parent reply other threads:[~2026-01-22 14:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 12:23 [PATCH 0/3] manage net/null dependency for tests Bruce Richardson
2026-01-22 12:23 ` [PATCH 1/3] test/bpf: skip some testing if null net driver not present Bruce Richardson
2026-01-22 16:19 ` Stephen Hemminger
2026-01-22 16:23 ` Bruce Richardson
2026-01-22 22:17 ` [PATCH] test/bpf: skip the BPF ELF load tests if net null missing Stephen Hemminger
2026-01-23 7:55 ` Morten Brørup
2026-02-16 14:58 ` David Marchand
2026-01-22 12:23 ` [PATCH 2/3] test: fix missing dependency on null networking driver Bruce Richardson
2026-01-22 12:23 ` [PATCH 3/3] drivers: always enable the null net driver [RFC] Bruce Richardson
2026-01-22 13:13 ` Morten Brørup
2026-01-22 13:31 ` Bruce Richardson
2026-01-22 13:40 ` Morten Brørup
2026-01-22 14:59 ` Bruce Richardson [this message]
2026-01-22 16:09 ` Stephen Hemminger
2026-01-22 13:47 ` David Marchand
2026-01-22 14:57 ` Bruce Richardson
2026-01-22 15:37 ` Morten Brørup
2026-02-19 17:39 ` [PATCH v2 0/4] improve net/null dependency handling for tests Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 1/4] test/event_eth_rx_adapter: skip tests if no ethdevs Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 2/4] test/event_eth_tx_adapter: remove dependency on NULL PMD Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 3/4] test: fix missing dependency on null networking driver Bruce Richardson
2026-02-19 17:39 ` [PATCH v2 4/4] build/tests: add warning for missing NULL PMD dependency Bruce Richardson
2026-02-19 19:44 ` [PATCH v2 0/4] improve net/null dependency handling for tests Morten Brørup
2026-03-03 16:29 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXI7STpuEtMWQloB@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox