From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] examples/ethtool: fix error message about ports limit
Date: Wed, 28 Jan 2026 10:43:44 +0000 [thread overview]
Message-ID: <aXnoYJo_ZJ68zodC@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260128103350.2730104-1-thomas@monjalon.net>
On Wed, Jan 28, 2026 at 11:33:50AM +0100, Thomas Monjalon wrote:
> The error message about the number of ports was swapping
> the desired and maximum number of ports.
>
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> examples/ethtool/ethtool-app/main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c
> index d380f69cea..b6bbae70d2 100644
> --- a/examples/ethtool/ethtool-app/main.c
> +++ b/examples/ethtool/ethtool-app/main.c
> @@ -288,9 +288,7 @@ int main(int argc, char **argv)
> if (cnt_ports == 0)
> rte_exit(EXIT_FAILURE, "No available NIC ports!\n");
> if (cnt_ports > MAX_PORTS) {
> - printf("Info: Using only %i of %i ports\n",
> - cnt_ports, MAX_PORTS
> - );
> + printf("Info: Using only %i of %i ports\n", MAX_PORTS, cnt_ports);
> cnt_ports = MAX_PORTS;
> }
>
> --
> 2.52.0
>
next prev parent reply other threads:[~2026-01-28 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 10:33 [PATCH] examples/ethtool: fix error message about ports limit Thomas Monjalon
2026-01-28 10:43 ` Bruce Richardson [this message]
2026-02-16 22:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXnoYJo_ZJ68zodC@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox