From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>, Kai Ji <kai.ji@intel.com>,
Gagandeep Singh <g.singh@nxp.com>,
Igor Russkikh <irusskikh@marvell.com>,
Steven Webster <steven.webster@windriver.com>,
Matt Peters <matt.peters@windriver.com>,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v2] license: standardize SPDX tag
Date: Wed, 28 Jan 2026 17:46:57 +0000 [thread overview]
Message-ID: <aXpLkZDEFhW0Goqi@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <11418515.5MRjnR8RnV@thomas>
On Wed, Jan 28, 2026 at 06:44:54PM +0100, Thomas Monjalon wrote:
> 28/01/2026 17:30, Bruce Richardson:
> > On Wed, Jan 28, 2026 at 05:20:52PM +0100, Thomas Monjalon wrote:
> > > In the Linux Foundation SPDX recommendation,
> > > there is no need of parentheses when 2 licenses are possible:
> > > https://spdx.dev/learn/handling-license-info/
> > >
> > > The useless parentheses and spaces are removed,
> > > the keyword "OR" is uppercased, and the comment starts with /*
> > >
> > > The script check-spdx-tag.sh is updated to detect some syntax errors.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > I actually think this would be better as two patches - one for making the
> > changes across the various files and then a second to update the script and
> > readme.
>
> Why?
> I like when new rules, applying them and checking them
> are done in an atomic way.
>
Because it mixes mechanical changes which don't need much review with real
code changes in the checker which needs more careful code review.
/Bruce
next prev parent reply other threads:[~2026-01-28 17:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 9:13 [PATCH] license: standardize SPDX tag for 3-Clause BSD Thomas Monjalon
2025-11-12 9:31 ` Bruce Richardson
2025-11-12 9:38 ` Thomas Monjalon
2025-11-12 9:41 ` Bruce Richardson
2025-11-12 9:43 ` Thomas Monjalon
2026-01-14 6:00 ` Stephen Hemminger
2026-01-28 16:20 ` [PATCH v2] license: standardize SPDX tag Thomas Monjalon
2026-01-28 16:30 ` Bruce Richardson
2026-01-28 17:44 ` Thomas Monjalon
2026-01-28 17:46 ` Bruce Richardson [this message]
2026-02-04 20:46 ` [PATCH v3 0/2] " Thomas Monjalon
2026-02-04 20:46 ` [PATCH v3 1/2] license: " Thomas Monjalon
2026-02-05 5:34 ` Hemant Agrawal
2026-02-04 20:46 ` [PATCH v3 2/2] devtools: check SPDX syntax Thomas Monjalon
2026-02-05 1:41 ` [PATCH v3 0/2] standardize SPDX tag Stephen Hemminger
2026-02-05 8:44 ` Bruce Richardson
2026-02-05 14:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXpLkZDEFhW0Goqi@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=irusskikh@marvell.com \
--cc=kai.ji@intel.com \
--cc=kishore.padmanabha@broadcom.com \
--cc=matan@nvidia.com \
--cc=matt.peters@windriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=orika@nvidia.com \
--cc=sachin.saxena@nxp.com \
--cc=steven.webster@windriver.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox