Re: [PATCH v2] license: standardize SPDX tag

Bruce Richardson
2026-01-28T17:47:14Z

On Wed, Jan 28, 2026 at 06:44:54PM +0100, Thomas Monjalon wrote:
> 28/01/2026 17:30, Bruce Richardson:
> > On Wed, Jan 28, 2026 at 05:20:52PM +0100, Thomas Monjalon wrote:
> > > In the Linux Foundation SPDX recommendation,
> > > there is no need of parentheses when 2 licenses are possible:
> > > https://spdx.dev/learn/handling-license-info/
> > >
> > > The useless parentheses and spaces are removed,
> > > the keyword "OR" is uppercased, and the comment starts with /*
> > >
> > > The script check-spdx-tag.sh is updated to detect some syntax errors.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > I actually think this would be better as two patches - one for making the
> > changes across the various files and then a second to update the script and
> > readme.
>
> Why?
> I like when new rules, applying them and checking them
> are done in an atomic way.
>
Because it mixes mechanical changes which don't need much review with real
code changes in the checker which needs more careful code review.

/Bruce