From: Bruce Richardson <bruce.richardson@intel.com>
To: Lukas Sismis <sismis@dyna-nic.com>
Cc: <dev@dpdk.org>, <stephen@networkplumber.org>
Subject: Re: [PATCH v8 1/6] cmdline: include stddef.h for MSVC compatibility
Date: Thu, 29 Jan 2026 11:43:20 +0000 [thread overview]
Message-ID: <aXtH2KV9p3PyQazu@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260129114202.61185-2-sismis@dyna-nic.com>
On Thu, Jan 29, 2026 at 12:41:57PM +0100, Lukas Sismis wrote:
> Include <stddef.h> at the top of cmdline_parse.h before the
> fallback offsetof macro definition. This improves MSVC build
> compatibility by ensuring the standard offsetof is available
> before the fallback definition, avoiding macro redefinition
> warnings when building with /WX (warnings as errors).
>
> The standard header provides offsetof on all platforms, and
> including it first ensures the fallback is only used when truly
> needed.
>
> Signed-off-by: Lukas Sismis <sismis@dyna-nic.com>
> ---
> lib/cmdline/cmdline_parse.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h
> index d9a7d86256..c4131e4af5 100644
> --- a/lib/cmdline/cmdline_parse.h
> +++ b/lib/cmdline/cmdline_parse.h
> @@ -7,6 +7,8 @@
> #ifndef _CMDLINE_PARSE_H_
> #define _CMDLINE_PARSE_H_
>
> +#include <stddef.h>
> +
> #ifdef __cplusplus
> extern "C" {
> #endif
> --
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-01-29 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 11:41 [PATCH v8 0/6] flow_parser: add shared parser library Lukas Sismis
2026-01-29 11:41 ` [PATCH v8 1/6] cmdline: include stddef.h for MSVC compatibility Lukas Sismis
2026-01-29 11:43 ` Bruce Richardson [this message]
2026-01-29 11:41 ` [PATCH v8 2/6] ethdev: add RSS type helper APIs Lukas Sismis
2026-01-29 11:42 ` [PATCH v8 4/6] app/testpmd: use shared flow parser library Lukas Sismis
2026-01-29 11:42 ` [PATCH v8 5/6] examples/flow_parsing: add flow parser demo Lukas Sismis
2026-01-29 11:42 ` [PATCH v8 6/6] test: add flow parser library functional tests Lukas Sismis
[not found] ` <20260129114202.61185-4-sismis@dyna-nic.com>
2026-01-29 17:23 ` [PATCH v8 3/6] flow_parser: add shared parser library Stephen Hemminger
2026-01-29 17:28 ` Stephen Hemminger
2026-01-30 12:13 ` Lukáš Šišmiš
2026-01-31 21:24 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXtH2KV9p3PyQazu@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sismis@dyna-nic.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox