Re: [PATCH] net/iavf: explicitly pass flags param to Tx context fns

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Feb 19, 2026 at 04:25:52PM +0000, Medvedkin, Vladimir wrote:
> 
> On 2/19/2026 4:07 PM, Bruce Richardson wrote:
> > The get_context_desc() function takes as an explicit parameter the
> > ol_flags from the packet, which saves re-reading them from the mbuf. The
> > subfunctions for creating the segmentation part of the descriptor or the
> > ipsec handling do not take this parameter though, and then re-read the
> > ol_flags from the mbuf. While essentially harmless, this does confuse
> > static analysis tools like converity which does not realise that
> > ol_flags and m->ol_flags are the same, leading to false positives
> > like [1].
> > 
> > Fix this and avoid coverity false positives by just passing the local
> > ol_flags variable so all code uses the same flags source and avoid
> > unnecessary mbuf reads.
> > 
> > [1] Coverity Issue: 501497
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > NOTE: Not flagging this as a bugfix since there is no actual bug here,
> > just a code improvement to try and prevent false positives.
> > ---
> >   drivers/net/intel/iavf/iavf_rxtx.c | 20 ++++++++++----------
> >   1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Applied to dpdk-next-net-intel.

/Bruce