From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] test/eal: remove PCI probing for vdev tests
Date: Mon, 23 Feb 2026 17:01:03 +0000 [thread overview]
Message-ID: <aZyHzxvNjboxwDs7@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260223155603.3651641-1-david.marchand@redhat.com>
On Mon, Feb 23, 2026 at 04:56:03PM +0100, David Marchand wrote:
> Similarly to commit f67f76e6bbfd ("test/eal: remove PCI probing for
> recursive calls"), let's disable PCI probing in vdev tests as it
> triggers false positive failures in GHA.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> app/test/test_eal_flags.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index bebddf1c98..06a605cce1 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -422,17 +422,17 @@ test_invalid_vdev_flag(void)
>
> /* Test with invalid vdev option */
> const char *vdevinval[] = {prgname, prefix, no_huge, eal_debug_logs,
> - bus_debug_logs, vdev, "eth_dummy"};
> + bus_debug_logs, no_pci, vdev, "eth_dummy"};
>
> /* Test with valid vdev option */
> const char *vdevval1[] = {prgname, prefix, no_huge, eal_debug_logs,
> - bus_debug_logs, vdev, "net_ring0"};
> + bus_debug_logs, no_pci, vdev, "net_ring0"};
>
> const char *vdevval2[] = {prgname, prefix, no_huge, eal_debug_logs,
> - bus_debug_logs, vdev, "net_ring0,args=test"};
> + bus_debug_logs, no_pci, vdev, "net_ring0,args=test"};
>
> const char *vdevval3[] = {prgname, prefix, no_huge, eal_debug_logs,
> - bus_debug_logs, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
> + bus_debug_logs, no_pci, vdev, "net_ring0,nodeaction=r1:0:CREATE"};
>
> if (launch_proc(vdevinval) == 0) {
> printf("Error (line %d) - process did run ok with invalid vdev parameter\n",
> --
> 2.53.0
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-02-23 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 15:56 [PATCH] test/eal: remove PCI probing for vdev tests David Marchand
2026-02-23 17:01 ` Bruce Richardson [this message]
2026-02-23 17:16 ` Marat Khalili
2026-02-24 7:48 ` David Marchand
2026-02-24 7:49 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZyHzxvNjboxwDs7@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox