From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v1 5/5] test: support for rawdev testcases Date: Tue, 16 Jan 2018 15:37:46 +0530 Message-ID: References: <20180102125749.2379-1-shreyansh.jain@nxp.com> <20180102125749.2379-6-shreyansh.jain@nxp.com> <2256187.Km34roPN7u@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , To: Thomas Monjalon Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0050.outbound.protection.outlook.com [104.47.34.50]) by dpdk.org (Postfix) with ESMTP id 92B1C12001 for ; Tue, 16 Jan 2018 10:53:37 +0100 (CET) In-Reply-To: <2256187.Km34roPN7u@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Monday 15 January 2018 04:28 AM, Thomas Monjalon wrote: > 02/01/2018 13:57, Shreyansh Jain: >> Patch introduces rawdev unit testcase for validation against the >> Skeleton rawdev dummy PMD implementation. >> >> Signed-off-by: Shreyansh Jain >> --- >> test/test/Makefile | 4 + >> test/test/test_rawdev.c | 376 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 380 insertions(+) > > As it is being done for test_eventdev_octeontx.c, I think it is > a good idea to move the PMD unit tests in the PMD directory. > Please check the patches from Pavan, applied in dpdk-next-eventdev. > > I saw the changes done by Pavan in eventdev-next. Issue I see here is that rte_test.h is currently in eventdev tree. That would mean either I don't use those macros, or use it with this series as dependency on master absorbing eventdev-next in near rc. I am assuming that post rc1 rte_test.h would be in master and thus it would be OK to apply this series over it during rc2. Is it OK with you? - Shreyansh