From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 3/3] net/ixgbe: enable flex bytes for generic
 flow API
Date: Tue, 23 May 2017 14:21:02 +0100
Message-ID: <aa4247fe-ac28-6d9b-7686-a3d96dbfe278@intel.com>
References: <1495511950-12130-1-git-send-email-qi.z.zhang@intel.com>
 <1495511950-12130-3-git-send-email-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Qi Zhang <qi.z.zhang@intel.com>, wenzhuo.lu@intel.com,
 helin.zhang@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 78A25374E
 for <dev@dpdk.org>; Tue, 23 May 2017 15:21:05 +0200 (CEST)
In-Reply-To: <1495511950-12130-3-git-send-email-qi.z.zhang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/23/2017 4:59 AM, Qi Zhang wrote:
> Add fdir flex byte support for rte_flow APIs.
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Hi Qi,

There are a few checkpatch errors for this patch also please find a few
minor syntax issues below.

<...>

> +int
> +ixgbe_fdir_set_flexbytes_offset(struct rte_eth_dev *dev,
> +				uint16_t offset)
> +{
> +	uint32_t fdirctrl;
> +	int i;
> +	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);

We don't have "reverse christmas tree declarations", right J

<...>

> +
> +		/*Not supported last point for range*/

Spaces around comment.

<...>

> +		/**
> +		 * mask should not be null
> +		 */

Can have single line comment.