From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] app/testpmd: check if CRC strip offload
 supported
Date: Fri, 11 May 2018 17:27:32 +0100
Message-ID: <aa4276c6-68f5-7a5c-2bad-be501827fc51@intel.com>
References: <20180509220904.128983-1-ferruh.yigit@intel.com>
 <DB7PR05MB442632DC51BC1B8C308F27AAC3980@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <8CEF83825BEC744B83065625E567D7C24E0CA496@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Dai, Wei" <wei.dai@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 Shahaf Shuler <shahafs@mellanox.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 56C1B1C80B
 for <dev@dpdk.org>; Fri, 11 May 2018 18:27:36 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CA496@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/11/2018 4:36 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
>> Sent: Thursday, May 10, 2018 5:39 AM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload
>> supported
>>
>> Thursday, May 10, 2018 1:09 AM, Ferruh Yigit:
>>> Subject: [PATCH] app/testpmd: check if CRC strip offload supported
>>>
>>> Testpmd set CRC_STRIP offload blindly, this is wrong according offload
>>> API definition, and will cause error for the PMDs that doesn't support
>>> CRC_STRIP like virtual PMDs.
>>>
>>> Check if underlying device report this capability and don't set it if
>>> not supported.
>>>
>>> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
>>> Cc: shahafs@mellanox.com
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Yes this is the correct behavior. I hope all the PMDs report the CRC strip
>> correctly.
>>
>> Acked-by: Shahaf Shuler < shahafs@mellanox.com>
> 
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>

Applied to dpdk-next-net/master, thanks.