From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] igb_uio: fail and log if kernel lock down
 is enabled
Date: Fri, 29 Jun 2018 10:35:51 +0100
Message-ID: <aa74919f-6932-62c0-c1f7-cf491c3921d2@intel.com>
References: <20180516101851.2443-1-ferruh.yigit@intel.com>
 <20180516144220.21235-1-ferruh.yigit@intel.com>
 <CALwxeUvWKqbq1kSp8zOozH63Cj19XcvVsTQv0J+UTyR6JgJUqQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 Luca Boccassi <bluca@debian.org>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Neil Horman <nhorman@tuxdriver.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id CDB001B4BD
 for <dev@dpdk.org>; Fri, 29 Jun 2018 11:35:55 +0200 (CEST)
In-Reply-To: <CALwxeUvWKqbq1kSp8zOozH63Cj19XcvVsTQv0J+UTyR6JgJUqQ@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/29/2018 8:04 AM, David Marchand wrote:
> Hello Ferruh,
> 
> On Wed, May 16, 2018 at 4:42 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> @@ -136,3 +132,22 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev)
>>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 5, 0)
>>  #define HAVE_PCI_MSI_MASK_IRQ 1
>>  #endif
>> +
>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 8, 0)
>> +#define HAVE_ALLOC_IRQ_VECTORS 1
>> +#endif
>> +
>> +static inline bool igbuio_kernel_is_locked_down(void)
>> +{
>> +#ifdef CONFIG_LOCK_DOWN_KERNEL
>> +#ifdef CONFIG_LOCK_DOWN_IN_EFI_SECURE_BOOT
>> +       return kernel_is_locked_down(NULL);
>> +#elif CONFIG_EFI_SECURE_BOOT_LOCK_DOWN
>> +       return kernel_is_locked_down();
>> +#else
>> +       return false;
>> +#endif
>> +#else
>> +       return false;
>> +#endif
>> +}
> 
> Missing some defined() for the check on CONFIG_EFI_SECURE_BOOT_LOCK_DOWN.
> It causes a build error with ubuntu-16.04 hwe for aarch64.
> 
> I can send a patch.

Hi David,

You are right, please send the patch if have bandwidth for it, thanks.