From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [RFC PATCH 0/6] change legacy linuxapp/bsdapp names Date: Wed, 13 Mar 2019 15:14:27 +0000 Message-ID: References: <20190306162242.65375-1-bruce.richardson@intel.com> <19421689.NtES9yoMkj@xps> <2347388.E9kf87BXsl@xps> <851ec589-621b-c31e-7198-cd3b9e5ddd68@intel.com> <20190313144310.GA1169924@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , dev@dpdk.org To: Bruce Richardson Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CA6514C95 for ; Wed, 13 Mar 2019 16:14:32 +0100 (CET) In-Reply-To: <20190313144310.GA1169924@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/13/2019 2:43 PM, Bruce Richardson wrote: > On Wed, Mar 13, 2019 at 02:21:31PM +0000, Ferruh Yigit wrote: >> On 3/13/2019 1:59 PM, Thomas Monjalon wrote: >>> 13/03/2019 14:41, Ferruh Yigit: >>>> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: >>>>>> Bruce Richardson (6): >>>>>> eal/bsdapp: rename to freebsd >>>>>> eal/linuxapp: rename to linux >>>>>> build/linux: rename macro from LINUXAPP to LINUX >>>>>> build/freebsd: rename macro from BSDPAPP to FREEBSD >>>>>> build/meson: change linuxapp to linux in meson cross files >>>>>> build: allow linux and freebsd in build configs >>>>> >>>>> Applied, thanks >>>> >>>> This has potential to break some automation/scripts since changes the names of >>>> the config files: >>>> 'make T=x86_64-native-linuxapp-gcc config' becomes >>>> 'make T=x86_64-native-linux-gcc config' etc... >>>> >>>> I suggest highlighting this change in release notes! >>> >>> No, the old names should still work. >>> Otherwise, it would be an API breakage, which is very bad! >>> >> >> Ah, right config is working, how I hit this is: >> >> $ make T=x86_64-native-linuxapp-gcc cscope >> Invalid config: x86_64-native-linuxapp-gcc >> >> 'cscope' (and friends) also should be covered ... > > Strange, because the new configs are just symlinks to the old. I'll need to > investigate how cscope and friends use the config. Are we allowed to use symlinks J Will they play nice on windows?