From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v2 01/22] eal: introduce one device scan Date: Thu, 21 Jun 2018 08:56:21 +0100 Message-ID: References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180621020059.1198-1-qi.z.zhang@intel.com> <20180621020059.1198-2-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com To: Qi Zhang , thomas@monjalon.net Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 407051BB2A for ; Thu, 21 Jun 2018 09:56:25 +0200 (CEST) In-Reply-To: <20180621020059.1198-2-qi.z.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21-Jun-18 3:00 AM, Qi Zhang wrote: > When hot plug a new device, it is not necessary to scan everything > on the bus since the devname and devargs are already there. So new > rte_bus ops "scan_one" is introduced, bus driver can implement this > function to simplify the hotplug process. > > Signed-off-by: Qi Zhang > --- > > +/** > * Implementation specific probe function which is responsible for linking > * devices on that bus with applicable drivers. > * > @@ -204,6 +219,7 @@ struct rte_bus { > TAILQ_ENTRY(rte_bus) next; /**< Next bus object in linked list */ > const char *name; /**< Name of the bus */ > rte_bus_scan_t scan; /**< Scan for devices attached to bus */ > + rte_bus_scan_one_t scan_one; /**< Scan one device using devargs */ > rte_bus_probe_t probe; /**< Probe devices on bus */ > rte_bus_find_device_t find_device; /**< Find a device on the bus */ > rte_bus_plug_t plug; /**< Probe single device for drivers */ > Does this break ABI for bus? -- Thanks, Anatoly