From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] examples/flow_filtering: fix example
 documentation
Date: Wed, 2 Jan 2019 14:52:42 +0000
Message-ID: <aae68393-c1de-3f24-6ad6-012936d62ea7@intel.com>
References: <1545648636-36614-1-git-send-email-dekelp@mellanox.com>
 <AM4PR05MB34251A56F705FDB7A4656619DBB40@AM4PR05MB3425.eurprd05.prod.outlook.com>
 <VI1PR05MB422485D5F09281E24BB50B74B6B40@VI1PR05MB4224.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Dekel Peled <dekelp@mellanox.com>, Ori Kam <orika@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id DC26D1B2AB
 for <dev@dpdk.org>; Wed,  2 Jan 2019 15:52:45 +0100 (CET)
In-Reply-To: <VI1PR05MB422485D5F09281E24BB50B74B6B40@VI1PR05MB4224.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/25/2018 6:30 AM, Dekel Peled wrote:
> PSB.
> 
>> -----Original Message-----
>> From: Ori Kam
>> Sent: Tuesday, December 25, 2018 5:25 AM
>> To: Dekel Peled <dekelp@mellanox.com>
>> Cc: dev@dpdk.org; Dekel Peled <dekelp@mellanox.com>
>> Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: fix example
>> documentation
>>
>>
>>
>>> -----Original Message-----
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
>>> Sent: Monday, December 24, 2018 12:51 PM
>>> To: Ori Kam <orika@mellanox.com>
>>> Cc: dev@dpdk.org; Dekel Peled <dekelp@mellanox.com>
>>> Subject: [dpdk-dev] [PATCH] examples/flow_filtering: fix example
>>> documentation
>>>
>>> Previous patch removed the VLAN item from example code.
>>> This patch fixes the documentation accordingly.
>>
>> So why are you modifying the c file?
>>
> 
> The doc file quotes the c file, needed to modify both to align doc with code.
> Code change includes fix of comments, and removing redundant variables and their initialization.

What about removing the code from doc file, it is guaranteed that it will be
outdated again? Or perhaps just add pseudo code if required.