From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC702C433E1 for ; Mon, 13 Jul 2020 12:29:35 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 80F3520738 for ; Mon, 13 Jul 2020 12:29:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80F3520738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C86FD1D689; Mon, 13 Jul 2020 14:29:34 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A5F481D686 for ; Mon, 13 Jul 2020 14:29:32 +0200 (CEST) IronPort-SDR: +ncxIeqlgEId3JkQAcdOK2HVATP/SVbL6bA1/iaOCo29bz0KCuHGLu3VUQgOpY6MG+QgfiMbxB 5nc3PwOR+zNw== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="136767207" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="136767207" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 05:29:31 -0700 IronPort-SDR: y4SROh1g1RsEtF2bRkfzCA+uoGkkETXq0Qj88EAFbK4Yc7It/bTKWTWuURyMWf3YUTGIO+qo3D z/GC2EmIVFZg== X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459274741" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.247.148]) ([10.213.247.148]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 05:29:30 -0700 To: Anatoly Burakov , dev@dpdk.org Cc: reshma.pattan@intel.com References: <1ab5d183405f1e1525799310eb1d38a3c88b7009.1594642553.git.anatoly.burakov@intel.com> From: "Hunt, David" Message-ID: Date: Mon, 13 Jul 2020 13:29:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1ab5d183405f1e1525799310eb1d38a3c88b7009.1594642553.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix updating performance lcore parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/7/2020 1:15 PM, Anatoly Burakov wrote: > When perf-config option is specified, we are calling into the power > library even though it may not necessarily be enabled. It is > questionable whether perf-config option is even applicable to non-power > library modes, but for now, fix it just by avoiding calling into the > power library if it wasn't initialized, and assume that every lcore is > high performance core. > > Fixes: e0194feb322c ("examples/l3fwd-power: add interrupt-only mode") > > Signed-off-by: Anatoly Burakov > --- > examples/l3fwd-power/perf_core.c | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-) We saw a segfault with the following use-case: ./l3fwd-power -l 0,1 -- -p 0x1 -P --perf-config="(0,0,1,0)" I've tested it and now runs without segfault. Acked-by: David Hunt