From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 08/18] net/axgbe: add transmit and receive
 queue setup apis
Date: Mon, 9 Apr 2018 13:30:34 +0100
Message-ID: <ab640107-71f1-dda5-5e62-81ceb80c36ec@intel.com>
References: <1522910389-35530-1-git-send-email-Ravi1.kumar@amd.com>
 <1523018211-65765-1-git-send-email-Ravi1.kumar@amd.com>
 <1523018211-65765-8-git-send-email-Ravi1.kumar@amd.com>
 <9B0331B6EBBD0E4684FBFAEDA55776F95319F65B@HASMSX110.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: "Rosen, Rami" <rami.rosen@intel.com>, Ravi Kumar <Ravi1.kumar@amd.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id F13781B801
 for <dev@dpdk.org>; Mon,  9 Apr 2018 14:30:37 +0200 (CEST)
In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F95319F65B@HASMSX110.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/9/2018 5:49 AM, Rosen, Rami wrote:
> +static void
> +axgbe_dev_info_get(struct rte_eth_dev *dev,
> +		   struct rte_eth_dev_info *dev_info) {
> +	struct axgbe_port *pdata = dev->data->dev_private;
> +
> +	dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> 
> 
> [Rami Rosen] Shouldn't it be here:
> 	dev_info->max_rx_queues = pdata->rx_ring_count;
> 	dev_info->max_tx_queues = pdata->tx_ring_count;
> 
> 
> +	dev_info->max_rx_queues = pdata->tx_ring_count;
> +	dev_info->max_tx_queues = pdata->rx_ring_count;


Yes, good catch. Can either you or Ravi send a fix please? I can squash it.